refactor: drive visit() switches from existing X-macro .inc files#1194
Merged
gennaroprota merged 1 commit intoMay 5, 2026
Conversation
|
| Scope | Lines Δ% | Lines Δ | Lines + | Lines - | Files Δ | Files + | Files ~ | Files ↔ | Files - |
|---|---|---|---|---|---|---|---|---|---|
| 🛠️ Source | 100% | 80 | 19 | 61 | 3 | - | 3 | - | - |
| Total | 100% | 80 | 19 | 61 | 3 | - | 3 | - | - |
Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)
🔝 Top Files
- include/mrdocs/Metadata/Type.hpp (Source): 44 lines Δ (+7 / -37)
- include/mrdocs/Metadata/TArg.hpp (Source): 18 lines Δ (+6 / -12)
- include/mrdocs/Metadata/TParam.hpp (Source): 18 lines Δ (+6 / -12)
gennaroprota
force-pushed
the
refactor/drive_visit_switches_from_existing_xmacro_inc_files
branch
from
6bc06db to
a0dcd2b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1194 +/- ##
========================================
Coverage 82.12% 82.12%
========================================
Files 33 33
Lines 3149 3149
Branches 734 734
========================================
Hits 2586 2586
Misses 387 387
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
An automated preview of the documentation is available at https://1194.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-05-04 06:03:58 UTC |
gennaroprota
force-pushed
the
refactor/drive_visit_switches_from_existing_xmacro_inc_files
branch
from
a0dcd2b to
5b2c18c
Compare
alandefreitas
approved these changes
May 1, 2026
The hand-coded `visit()` switches in Type.hpp, TArg.hpp, and TParam.hpp were duplicating the type list already enumerated by their respective *Nodes.inc X-macro files. This rewrites each to consume the .inc file, instead, matching the pattern Symbol.hpp, Name.hpp, Block.hpp, Inline.hpp already use, so the .inc is the single source of truth.
gennaroprota
force-pushed
the
refactor/drive_visit_switches_from_existing_xmacro_inc_files
branch
from
5b2c18c to
d352f49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hand-coded
visit()switches in Type.hpp, TArg.hpp, and TParam.hpp were duplicating the type list already enumerated by their respective *Nodes.inc X-macro files. This rewrites each to consume the .inc file, instead, matching the pattern Symbol.hpp, Name.hpp, Block.hpp, Inline.hpp already use, so the .inc is the single source of truth.